Csv import overwrite enabled #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
reviewed
Nov 11, 2021
There was a problem hiding this comment.
LGTM, Kindly also update the documentation here https://stage-api.ona.io/static/docs/forms.html#import-csv-data-to-existing-form; To highlight that during an overwrite we don't consider the _uuid of the imported data.
denniswambua
force-pushed
the
csv_import_overite_enabled
branch
from
ad896b0
to
115c074
Compare
DavisRayM
reviewed
Nov 17, 2021
DavisRayM
previously approved these changes
Nov 17, 2021
denniswambua
force-pushed
the
csv_import_overite_enabled
branch
from
52a482e
to
737abaf
Compare
DavisRayM
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Fix csv import overwrite which only updated the soft deleted submissions.
Steps taken to verify this change does what is intended
Tests included
Side effects of implementing this change
Uuids will always be generated for all the csv import modes.
Before submitting this PR for review, please make sure you have:
Closes #