Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export builder circular import #2208

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Mar 8, 2022

Signed-off-by: Kipchirchir Sigei [email protected]

Changes / Features implemented

  • Fix str_to_bool circular import

Steps taken to verify this change does what is intended

Side effects of implementing this change

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

@KipSigei KipSigei requested a review from DavisRayM March 8, 2022 14:27
Copy link
Contributor

@DavisRayM DavisRayM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A bit weird that this passed our test cases

@DavisRayM DavisRayM enabled auto-merge March 8, 2022 14:35
@DavisRayM DavisRayM merged commit 99d6840 into master Mar 8, 2022
@DavisRayM DavisRayM deleted the fix-circular-dependency branch March 8, 2022 16:50
@KipSigei KipSigei mentioned this pull request Mar 8, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants