Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest Pyxform version #2227

Merged
merged 27 commits into from
Apr 24, 2022
Merged

Upgrade to latest Pyxform version #2227

merged 27 commits into from
Apr 24, 2022

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Apr 12, 2022 •
edited
Loading

Changes / Features implemented

  • Upgrade to pyxform v1.9.0
  • Add support for geojson attachments

Steps taken to verify this change does what is intended

  • Refactored tests

Side effects of implementing this change

  • xlsx is no longer supported by xlrd, refactored to use openpyxl for xlsx files

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

@KipSigei
Dont build bytes object for csv files
985faf8 
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei
Update file paths
4b5cc2e 
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei force-pushed the pyxform-v1.9.0 branch 2 times, most recently from a132aac to 31199ae Compare April 22, 2022 15:32
@ukanga ukanga merged commit 7590619 into master Apr 24, 2022
@ukanga ukanga deleted the pyxform-v1.9.0 branch April 24, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KipSigei @ukanga