Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geojson simplestyle-spec support #2255

Merged
merged 10 commits into from
Jun 9, 2022

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Jun 9, 2022

Changes / Features implemented

  • Add geojson simplestyle-spec support
  • Optionally add title param to geojson properties
  • Add simple_style query param to enable simplestyle-spec

URL Example: https://stage-api.ona.io/api/v1/data/205.geojson?geo_field=trap_coordinates&simple_style=true&title=field_1

Steps taken to verify this change does what is intended

Side effects of implementing this change

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2240

@KipSigei KipSigei force-pushed the add-geojson-simplestyle-spec-support branch from 1ee0a39 to ad09b46 Compare June 9, 2022 06:06
@KipSigei KipSigei requested review from DavisRayM and ukanga June 9, 2022 06:07
Copy link
Member

@ukanga ukanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should plan to support only the simple style spec when we start on 4.x releases.

@KipSigei KipSigei force-pushed the add-geojson-simplestyle-spec-support branch from a0ebac3 to 2738e72 Compare June 9, 2022 10:12
ukanga
ukanga previously approved these changes Jun 9, 2022
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei merged commit 796a7a5 into main Jun 9, 2022
@KipSigei KipSigei deleted the add-geojson-simplestyle-spec-support branch June 9, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reformat the GeoJSON endpoint
3 participants