-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2266 link dataset as geojson #2272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KipSigei
force-pushed
the
2266-link-dataset-as-geojson
branch
from
June 27, 2022 10:17
6c8913f
to
6da4773
Compare
KipSigei
changed the title
[DNM] 2266 link dataset as geojson
2266 link dataset as geojson
Jun 27, 2022
KipSigei
force-pushed
the
2266-link-dataset-as-geojson
branch
6 times, most recently
from
July 1, 2022 08:04
49d8a24
to
94b4cde
Compare
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
2266-link-dataset-as-geojson
branch
from
July 1, 2022 11:19
8925a5f
to
9dd77ce
Compare
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
2266-link-dataset-as-geojson
branch
from
July 1, 2022 11:22
9dd77ce
to
51689a6
Compare
Signed-off-by: Kipchirchir Sigei <[email protected]>
ukanga
reviewed
Jul 1, 2022
docs/metadata.rst
Outdated
{ | ||
"id": 7121, | ||
"xform": 320, | ||
"data_value": "geojson 328 places", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the signature changed to xform_geojson 328 places
, is that the case? Please review and update accordingly.
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
2266-link-dataset-as-geojson
branch
from
July 4, 2022 07:22
7a7f223
to
4e4c696
Compare
ukanga
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
simple style
or as aFeatureCollection
Steps taken to verify this change does what is intended
Side effects of implementing this change
extra_data
to the Metadata Model, so running migrations might be neededBefore submitting this PR for review, please make sure you have:
Closes #2266