Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2266 link dataset as geojson #2272

Merged
merged 26 commits into from
Jul 4, 2022
Merged

2266 link dataset as geojson #2272

merged 26 commits into from
Jul 4, 2022

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Jun 27, 2022

Changes / Features implemented

  • Add support to Link xforms as GeoJSON attachments to a form
  • Add ability to transform the linked geojson as simple style or as a FeatureCollection

Steps taken to verify this change does what is intended

  • Added test cases

Side effects of implementing this change

  • Added a new field extra_data to the Metadata Model, so running migrations might be needed

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2266

@KipSigei KipSigei force-pushed the 2266-link-dataset-as-geojson branch from 6c8913f to 6da4773 Compare June 27, 2022 10:17
@KipSigei KipSigei changed the title [DNM] 2266 link dataset as geojson 2266 link dataset as geojson Jun 27, 2022
@KipSigei KipSigei force-pushed the 2266-link-dataset-as-geojson branch 6 times, most recently from 49d8a24 to 94b4cde Compare July 1, 2022 08:04
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei force-pushed the 2266-link-dataset-as-geojson branch from 8925a5f to 9dd77ce Compare July 1, 2022 11:19
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei force-pushed the 2266-link-dataset-as-geojson branch from 9dd77ce to 51689a6 Compare July 1, 2022 11:22
Signed-off-by: Kipchirchir Sigei <[email protected]>
{
"id": 7121,
"xform": 320,
"data_value": "geojson 328 places",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the signature changed to xform_geojson 328 places, is that the case? Please review and update accordingly.

@KipSigei KipSigei force-pushed the 2266-link-dataset-as-geojson branch from 7a7f223 to 4e4c696 Compare July 4, 2022 07:22
@KipSigei KipSigei requested a review from ukanga July 4, 2022 09:14
@KipSigei KipSigei merged commit b4b5ec5 into main Jul 4, 2022
@KipSigei KipSigei deleted the 2266-link-dataset-as-geojson branch July 4, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export GeoJSON as a media attachment
2 participants