Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the default ignored flake8 errors are actually ignored #2302

Closed
wants to merge 4 commits into from

Conversation

DavisRayM
Copy link
Contributor

Changes / Features implemented

  • Add default ignored codes to extend-ignore; Full list of default ignored codes can be seen on flake8 --help
  • Silence Flake8 E275 warning

Steps taken to verify this change does what is intended

N/A

Side effects of implementing this change

N/A

- For some reason it seems that the default ignored errors are no longer
  picked up by flake8 5.0.4; Usually the default list is cleared if
  `--ignore` is set but it doesn't seem like that's been set in the
  current codebase
@DavisRayM DavisRayM force-pushed the flake8-default-ignored-errors-fix branch from 7607b7a to 1544c6e Compare August 22, 2022 11:30
KipSigei
KipSigei previously approved these changes Aug 22, 2022
@DavisRayM
Copy link
Contributor Author

Closing since we'll be switching to prospector

@DavisRayM DavisRayM closed this Aug 22, 2022
@DavisRayM DavisRayM deleted the flake8-default-ignored-errors-fix branch August 22, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants