Order submission urls correctly #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciremusyoka
force-pushed
the
fix-submission-urls
branch
from
e141472
to
723f733
Compare
ciremusyoka
force-pushed
the
fix-submission-urls
branch
from
723f733
to
4c21e3e
Compare
ciremusyoka
requested review from
ukanga,
KipSigei and
DavisRayM
and removed request for
ukanga and
KipSigei
ukanga
requested changes
Sep 8, 2022
Comment on lines
+59
to
64
| form = get_object_or_404(XForm, pk=form_pk) | ||
| username = form.user.username | ||
| elif project_pk: | ||
| username = Project.objects.get(pk=project_pk).user.username | ||
| project = get_object_or_404(Project, pk=project_pk) | ||
| username = project.user.username | ||
| else: |
There was a problem hiding this comment.
Did we have a sentry or otherwise exceptions for this? Should we update tests that verify that the 404 is raised on this serializer?
There was a problem hiding this comment.
No we did not have a sentry report, I noted an exception while testing out and yes we should have tests to verify the 404.
ciremusyoka
force-pushed
the
fix-submission-urls
branch
from
ddc5fda
to
da0e54a
Compare
ukanga
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
part of https://github.com/onaio/zebra/issues/6353