Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove group name prefix for grouped gps fields #2316

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

KipSigei
Copy link
Contributor

Changes / Features implemented

  • Ensure the group name prefix is removed on gps headers when remove_group_name is set to true during exports

Steps taken to verify this change does what is intended

  • Added a test case to check if the group name is split when exporting

Side effects of implementing this change

  • None

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

@KipSigei KipSigei changed the title [WIP] Remove group name prefix on gps headers [WIP] Remove group name prefix for grouped gps fields Sep 19, 2022
@KipSigei KipSigei changed the title [WIP] Remove group name prefix for grouped gps fields Remove group name prefix for grouped gps fields Sep 19, 2022
DavisRayM
DavisRayM previously approved these changes Sep 19, 2022
DavisRayM
DavisRayM previously approved these changes Sep 20, 2022
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei merged commit c433fbb into main Sep 22, 2022
@KipSigei KipSigei deleted the fix-remove-group-prefix-bug branch September 22, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants