Add pagination to forms endpoint #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
changed the title
KipSigei
force-pushed
the
add-pagination-to-forms-endpoint
branch
from
19fab9b
to
1914a2e
Compare
KipSigei
force-pushed
the
add-pagination-to-forms-endpoint
branch
from
1914a2e
to
652f2c3
Compare
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
add-pagination-to-forms-endpoint
branch
2 times, most recently
from
067ff34
to
2e07021
Compare
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
add-pagination-to-forms-endpoint
branch
from
2e07021
to
0dbf25e
Compare
|
Should we paginate the response by default ? Perhaps only allow 1000 records or something of the sort ? I don't see the need to always return past 1000 records |
DavisRayM
approved these changes
Sep 29, 2022
|
@DavisRayM The response will always be paginated if there is a form, the condition added is to handle cases where there are no forms and page will end up being None/empty queryset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have: