Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to projects endpoint #2320

Merged
merged 5 commits into from
Sep 29, 2022
Merged

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Sep 29, 2022

Changes / Features implemented

  • Add pagination to projects endpoint

Steps taken to verify this change does what is intended

  • Tests

Side effects of implementing this change

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei changed the title [DNM] Add pagination to projects endpoint Add pagination to projects endpoint Sep 29, 2022
DavisRayM
DavisRayM previously approved these changes Sep 29, 2022
Copy link
Contributor

@DavisRayM DavisRayM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing, Can we add a note, that the default page size for XForms and Projects is 100,000 records ?

Other than that LGTM

@KipSigei KipSigei merged commit ab11478 into main Sep 29, 2022
@KipSigei KipSigei deleted the add-pagination-to-projects-endpoint branch September 29, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants