-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask users to provide a new google oauth credential if current one is invalid #2326
Ask users to provide a new google oauth credential if current one is invalid #2326
Conversation
7a3103c
to
fb6f249
Compare
54e84a9
to
d24ee08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FrankApiyo Could we add a test case for refreshing credentials and assert whether they are valid or not expired when the refresh is successful? |
This would be a bit tricky because we would need to provide an example of a valid google credential that would have to be attached to a google account, introducing a potentially flaky test since it would have to make an API request to google. I also think such a test would be testing google OAuth API and not our code, don't you think so? |
8469938
to
d2c37d6
Compare
d2c37d6
to
9ee1ee9
Compare
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have: