Propagate project permissions to all KPI Assets #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
formbuilder-permission-propagation
branch
7 times, most recently
from
1a87b55
to
94d3a55
Compare
DavisRayM
force-pushed
the
formbuilder-permission-propagation
branch
from
acdf99f
to
3fa3ac7
Compare
- Add `retrieve_asset_permissions` & `assign_change_asset_permission` utility functions - Add mechanism to remove permissions from users who no longer have a role tied to the project
…rmission functions
DavisRayM
force-pushed
the
formbuilder-permission-propagation
branch
2 times, most recently
from
6665203
to
80a8a2c
Compare
DavisRayM
force-pushed
the
formbuilder-permission-propagation
branch
from
80a8a2c
to
c987649
Compare
DavisRayM
force-pushed
the
formbuilder-permission-propagation
branch
from
e009328
to
c987649
Compare
DavisRayM
force-pushed
the
formbuilder-permission-propagation
branch
from
c6ba34b
to
e246be0
Compare
ukanga
approved these changes
Dec 7, 2022
KipSigei
reviewed
Dec 7, 2022
| # Propagate permissions for XForms that were published by | ||
| # Formbuilder | ||
| for form_id in form_ids: | ||
| asset: XForm = XForm.objects.get(id=form_id) |
There was a problem hiding this comment.
We should add a try catch block here so that if the xform doesnt exist in replica it can be fetched from master
There was a problem hiding this comment.
I think that might not be something we'd need to handle since this line should only return XForm objects that are available in the moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
TODO
Before submitting this PR for review, please make sure you have:
Closes #1060