Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure external select to csv conversion works as expected #2349

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Ensure external select to csv conversion works as expected #2349

merged 4 commits into from
Jan 20, 2023

Commits on Jan 19, 2023

  1. Recreate reported issue 

    - Issue is caused when a row within the `list_name` column is empty
  which leads to it being diagnosed as an integer field

- Update integer name column test to validate the generated CSV
    Davis Muro committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    366f063 View commit details
    Browse the repository at this point in the history

  2. Update sheet_to_csv function 

    - Ensure headers are not duplicated
- Ensure that integers & datetimes are correctly handler.
- Ensure empty values are not processed
- Utilize PyXForm `xlsx_value_to_str` to convert XLSX values
- Update tests
    Davis Muro committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    4f37461 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @DavisRayM
    DavisRayM committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    202eb58 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into external-selects-fix

    @DavisRayM
    DavisRayM committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    0524443 View commit details
    Browse the repository at this point in the history