Ensure that the user row is selected alongside the Token
#2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
previously approved these changes
Jan 31, 2023
KipSigei
previously approved these changes
Jan 31, 2023
KipSigei
reviewed
Feb 1, 2023
| @@ -157,7 +157,7 @@ def authenticate_credentials(self, key): | |||
| try: | |||
| if isinstance(key, bytes): | |||
| key = key.decode("utf-8") | |||
| token = self.model.objects.get(key=key) | |||
| token = self.model.objects.select_related("user").get(key=key) | |||
There was a problem hiding this comment.
@DavisRayM could we pin it to the master DB?
There was a problem hiding this comment.
I'd suggest we don't; In the except part of this we retrieve from master if we fail to retrieve from the read replica which I feel is a bit better
DavisRayM
force-pushed
the
2361-authentication-read-replica
branch
from
84a1ee7
to
764f28d
Compare
KipSigei
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
userrow is selected alongside the tokenCloses #2361