Correctly remove group name for GPS field headers for xlsx exports #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
previously approved these changes
Feb 2, 2023
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
fix-xlsx-export-group-name-bug-gps-headers
branch
from
69d15a3
to
c62c2f7
Compare
DavisRayM
suggested changes
Feb 3, 2023
| '_submitted_by' | ||
| ) | ||
| self.assertEqual(expected_headers, list(gps_sheet.values)[0]) | ||
|
|
There was a problem hiding this comment.
Can we also test the expected data ?
There was a problem hiding this comment.
To ensure that the values are actually correctly mapped
DavisRayM
previously approved these changes
Feb 3, 2023
KipSigei
force-pushed
the
fix-xlsx-export-group-name-bug-gps-headers
branch
from
1c71b89
to
ccea81b
Compare
DavisRayM
previously approved these changes
Feb 3, 2023
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
fix-xlsx-export-group-name-bug-gps-headers
branch
from
ccea81b
to
bc3dff8
Compare
DavisRayM
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kipchirchir Sigei [email protected]
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #2356