Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out deleted submissions from linked geojson #2371

Merged
merged 6 commits into from
Feb 14, 2023

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Feb 10, 2023

Signed-off-by: Kipchirchir Sigei [email protected]

Changes / Features implemented

  • Filter out deleted submissions when linking a dataset as GeoJSON

Steps taken to verify this change does what is intended

  • Tests

Side effects of implementing this change

  • The exported GeoJSON will only have active submissions

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei marked this pull request as ready for review February 10, 2023 07:42
Signed-off-by: Kipchirchir Sigei <[email protected]>
DavisRayM
DavisRayM previously approved these changes Feb 10, 2023
@KipSigei KipSigei force-pushed the remove-deleted-submissions-from-linked-geojson branch 2 times, most recently from 0711697 to 35dca82 Compare February 13, 2023 08:27
The latest version seems unstable

Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei force-pushed the remove-deleted-submissions-from-linked-geojson branch from 35dca82 to 24b78dd Compare February 13, 2023 08:50
Signed-off-by: Kipchirchir Sigei <[email protected]>
DavisRayM
DavisRayM previously approved these changes Feb 13, 2023
@KipSigei KipSigei merged commit a7d0649 into main Feb 14, 2023
@KipSigei KipSigei deleted the remove-deleted-submissions-from-linked-geojson branch February 14, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants