Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix keys in filtered dataset kwargs with 'instance__' #2380

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Prefix keys in filtered dataset kwargs with 'instance__' #2380

merged 4 commits into from
Feb 22, 2023

Conversation

FrankApiyo
Copy link
Member

@FrankApiyo FrankApiyo commented Feb 20, 2023 •
edited
Loading

Changes / Features implemented

Steps taken to verify this change does what is intended

  • Replicated the issue locally with a failing tests and fixed it
  • QAed

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2379

DavisRayM
DavisRayM reviewed Feb 21, 2023
View reviewed changes
onadata/libs/filters.py Outdated Show resolved Hide resolved
DavisRayM
DavisRayM reviewed Feb 21, 2023
View reviewed changes
onadata/libs/filters.py Outdated Show resolved Hide resolved
@FrankApiyo FrankApiyo merged commit a8557dd into main Feb 22, 2023
@FrankApiyo FrankApiyo deleted the fix-2379 branch February 22, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KipSigei KipSigei KipSigei approved these changes

@ciremusyoka ciremusyoka Awaiting requested review from ciremusyoka

@DavisRayM DavisRayM Awaiting requested review from DavisRayM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FieldError: Cannot resolve keyword 'json' into field from Attachment model
3 participants
@FrankApiyo @KipSigei @DavisRayM