Allow authenticated users to download public form exports #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciremusyoka
force-pushed
the
authenticated-users-public-exports
branch
from
827f08a
to
1f8f405
Compare
ukanga
requested changes
Mar 29, 2023
ukanga
reviewed
Mar 31, 2023
ukanga
previously approved these changes
Mar 31, 2023
KipSigei
previously approved these changes
Mar 31, 2023
… exports resolves #2284
ciremusyoka
force-pushed
the
authenticated-users-public-exports
branch
from
63ad0eb
to
c014c4f
Compare
KipSigei
approved these changes
Apr 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
AssertionError: renderer returned unicode, and did not specify a charset valuefor .zip, .savzip and .csvzip exportsSteps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Part of https://github.com/onaio/zebra/issues/7439