Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent numeric usernames on user creation #2407

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Conversation

KipSigei
Copy link
Contributor

Changes / Features implemented

  • Display error message when users register using numeric usernames

Steps taken to verify this change does what is intended

  • Tests

Side effects of implementing this change

  • No user will be allowed to register to the platform with numeric usernames

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2406

@KipSigei KipSigei force-pushed the prevent-numeric-usernames branch 2 times, most recently from 4c384ac to 4ad2ff8 Compare April 18, 2023 07:40
ukanga
ukanga previously approved these changes Apr 18, 2023
DavisRayM
DavisRayM previously approved these changes Apr 18, 2023
@KipSigei KipSigei force-pushed the prevent-numeric-usernames branch 8 times, most recently from f1d4e13 to 47d516e Compare April 20, 2023 07:06
DavisRayM
DavisRayM previously approved these changes Apr 20, 2023
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei merged commit 86247d1 into main Apr 20, 2023
@KipSigei KipSigei deleted the prevent-numeric-usernames branch April 20, 2023 07:48
@DavisRayM DavisRayM mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent users from creating an all numeric username
3 participants