Add ability to permanently delete submissions #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KipSigei
force-pushed
the
add-submissions-permanent-deletions-functionality
branch
3 times, most recently
from
6850bb5
to
3b374ac
Compare
| if enable_submission_permanent_delete: | ||
| instance.delete() | ||
| else: | ||
| error_msg = { |
There was a problem hiding this comment.
I think we should move this out of the loop else error_msg will be set for each instance
KipSigei
force-pushed
the
add-submissions-permanent-deletions-functionality
branch
from
3b374ac
to
4b14ce8
Compare
kelvin-muchiri
previously approved these changes
Jun 19, 2023
KipSigei
force-pushed
the
add-submissions-permanent-deletions-functionality
branch
from
f7a218d
to
6880703
Compare
kelvin-muchiri
previously approved these changes
Jun 20, 2023
ukanga
requested changes
Jun 21, 2023
KipSigei
force-pushed
the
add-submissions-permanent-deletions-functionality
branch
3 times, most recently
from
fed110e
to
7ef972c
Compare
ukanga
previously approved these changes
Jun 22, 2023
KipSigei
force-pushed
the
add-submissions-permanent-deletions-functionality
branch
from
7ef972c
to
0700dfc
Compare
ukanga
approved these changes
Jun 22, 2023
ukanga
requested changes
Jun 22, 2023
KipSigei
force-pushed
the
add-submissions-permanent-deletions-functionality
branch
from
0700dfc
to
49055c3
Compare
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
add-submissions-permanent-deletions-functionality
branch
from
49055c3
to
7734634
Compare
| self.assertEqual(self.xform.instances.count(), 3) | ||
| self.assertEqual(self.xform.num_of_submissions, 3) | ||
|
|
||
| @override_settings(ENABLE_SUBMISSION_PERMANENT_DELETE=True) |
There was a problem hiding this comment.
Let's add to the documentation what setting ENABLE_SUBMISSION_PERMANENT_DELETE is used for and its side effects
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
add-submissions-permanent-deletions-functionality
branch
from
7734634
to
f929305
Compare
kelvin-muchiri
approved these changes
Jun 26, 2023
ukanga
approved these changes
Jun 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
ENABLE_SUBMISSION_PERMANENT_DELETEto optionally enable/disable the functionalitySteps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #2431