Add task to permanently delete soft-deleted submissions #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KipSigei
force-pushed
the
automated-submission-deletions
branch
4 times, most recently
from
6bbaf9a
to
653c14d
Compare
KipSigei
force-pushed
the
automated-submission-deletions
branch
from
653c14d
to
0e8ae54
Compare
ukanga
reviewed
Jun 27, 2023
ukanga
requested changes
Jun 30, 2023
onadata/apps/api/tasks.py
Outdated
| """ | ||
| Task to periodically delete soft deleted submissions from db | ||
| """ | ||
| submissions_lifespan = getattr(settings, "INACTIVE_SUBMISSIONS_LIFESPAN", 365) |
There was a problem hiding this comment.
This line seems to define a hard limit of 365 days if the setting does not exist. Could we take the option of simply not taking any action if the setting is not defined/set? That will maintain the status quo as is now instead of on deployment all deleted items older than a year being removed. For some installations, this may not be ideal and prior communication may be necessary.
KipSigei
force-pushed
the
automated-submission-deletions
branch
from
7165fe6
to
d253557
Compare
KipSigei
force-pushed
the
automated-submission-deletions
branch
from
d253557
to
a79d95a
Compare
FrankApiyo
previously approved these changes
Jun 30, 2023
KipSigei
force-pushed
the
automated-submission-deletions
branch
from
278b05b
to
df6a028
Compare
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
automated-submission-deletions
branch
from
df6a028
to
86055b4
Compare
ukanga
reviewed
Jul 3, 2023
onadata/apps/api/tasks.py
Outdated
Comment on lines
126
to
127
| Q(deleted_at__isnull=False) | Q(deleted_at__gte=time_threshold), | ||
| date_created__lte=time_threshold, |
There was a problem hiding this comment.
Should this check be based only on the time since the record was last deleted hence using the deleted_at field for checks and not when the record was created?
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
automated-submission-deletions
branch
2 times, most recently
from
82055d3
to
d172194
Compare
ukanga
previously approved these changes
Jul 3, 2023
KipSigei
force-pushed
the
automated-submission-deletions
branch
from
d172194
to
713b55a
Compare
FrankApiyo
approved these changes
Jul 3, 2023
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
automated-submission-deletions
branch
from
713b55a
to
00fe783
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #