Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project and form level odk submission-list and download endpoints #2451

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Jul 14, 2023

Changes / Features implemented

Add project and form level odk submission list and download list filtering

Steps taken to verify this change does what is intended

Allows form and project level granularity of odk submission list and download list

Side effects of implementing this change

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

@KipSigei KipSigei changed the title Add project and form level odk submission-list and download-list endpoints Add project and form level odk submission-list and download endpoints Jul 14, 2023
@@ -201,11 +201,31 @@
BriefcaseViewset.as_view({"get": "list", "head": "list"}),
name="view-submission-list",
),
re_path(
r"^forms/(?P<xform_pk>\w+)/view/submissionList$",
Copy link
Contributor

@kelvin-muchiri kelvin-muchiri Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KipSigei Should we prefer submission-list over submissionList?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelvin-muchiri The endpoints are specific to the ODK Briefcase app and won't work if they are modified

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KipSigei KipSigei force-pushed the briefcase-fixes branch 3 times, most recently from 250ca65 to 045424e Compare September 4, 2023 09:14
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei merged commit 2221bbb into main Sep 4, 2023
8 checks passed
@KipSigei KipSigei deleted the briefcase-fixes branch September 4, 2023 10:19
@KipSigei KipSigei mentioned this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants