Enhance performance of open-data endpoint api/v2/open-data/<uuid>/data
#2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KipSigei
suggested changes
Jul 23, 2023
| self.data_count = ( | ||
| Instance.objects.filter(**qs_kwargs, deleted_at__isnull=True) | ||
| .only("pk") | ||
| .count() |
There was a problem hiding this comment.
Lets avoid doing an extra count query and use xform.num_of_submissions instead
There was a problem hiding this comment.
@KipSigei That would work, but we are applying filters so xform.num_of_submissions will not give us the correct result
use raw SQL queries to improve the performance
we are not using string formatting on raw queries or quote placeholders in the SQL strings as per the Django guidelines
order by is hurting the performance of the SQL query when then number of instances is very large
string interpolation exposes the query to SQL injection
kelvin-muchiri
force-pushed
the
improve-open-data-performance
branch
from
1aa55c4
to
b4db017
Compare
KipSigei
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
An improvement to the enhancements implemented here
GET api/v2/open-data/<uuid>/dataidin ascending order since when the number of submissions is large the query is extremely slow. There is also no reason to order the results by default. The consumers of the endpoint can carry out that functionality by themselvesSteps taken to verify this change does what is intended
Side effects of implementing this change
Faster response times for endpoint
GET api/v2/open-data/<uuid>/dataBefore submitting this PR for review, please make sure you have:
Closes #