Fix async submission count discrepancy #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KipSigei
force-pushed
the
fix-async-submission-counts-discrepancy
branch
2 times, most recently
from
6cf7869
to
51387b2
Compare
KipSigei
changed the title
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
fix-async-submission-counts-discrepancy
branch
from
51387b2
to
cc2e049
Compare
Signed-off-by: Kipchirchir Sigei <[email protected]>
ukanga
approved these changes
Sep 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Use transaction.on_commit() to ensure the post_save signal that updates submission count is executed only when a transaction is completed. More info on this change can be found here
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #