Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve intermittent bug where form permissions are not applied for new forms #2470

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Solve intermittent bug where form permissions are not applied for new forms #2470

merged 6 commits into from
Aug 17, 2023

Commits on Aug 15, 2023

  1. solve intermittent bug where form permissions are not applied 

    Django post_save signal is run at the end of of the Model.save() method. It is not guaranteed that the transaction will have commited. This leads to situation where XForm.DoesNotExist exception is at times raised when a new form is created
    @kelvin-muchiri
    kelvin-muchiri committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c32fb17 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. refactor code 

    do not call set_project_perms_to_xform asynchronously is the post_save signal when a new form is created
    @kelvin-muchiri
    kelvin-muchiri committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    14a43b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. refactor code

    @kelvin-muchiri
    kelvin-muchiri committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ca7d98d View commit details
    Browse the repository at this point in the history

  2. remove unnecessary CELERY_TASK_ALWAYS_EAGER override in tests

    @kelvin-muchiri
    kelvin-muchiri committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9edc99f View commit details
    Browse the repository at this point in the history

  3. fix failing tests

    @kelvin-muchiri
    kelvin-muchiri committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    a7e4366 View commit details
    Browse the repository at this point in the history

  4. refactor test case

    @kelvin-muchiri
    kelvin-muchiri committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d20defb View commit details
    Browse the repository at this point in the history