Revert to have data exports default sorting by id #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sort export data by id by default
kelvin-muchiri
requested review from
KipSigei,
ukanga,
FrankApiyo and
ciremusyoka
when fields are provided in the query no ordering is applied
sorting when fetching data is not applied when fetching data on select columns that are not json fields
ukanga
reviewed
Sep 13, 2023
Unexpected keyword argument 'json_only' in function call
get rid of ctypes.ArgumentError: error raised when working with GIS fields with Manager.raw() by selecting only the columns we need
FrankApiyo
approved these changes
Sep 13, 2023
KipSigei
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
api/v1/data/<form_id>.<format>#2460. This is affecting the index column hence record matching is a problem when exporting data in repeat groups.argument 3: TypeError: wrong typeraised when using including GIS fields inManager.rawwhen exporting non-OSM data by avoidSELECT *and selecting only the fields of interestSteps taken to verify this change does what is intended
Side effects of implementing this change
Default ordering on endpoint
api/v1/data/<form_id>.<format>by id ascending order is restoredBefore submitting this PR for review, please make sure you have:
Closes #