Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure geotrace and geoshape in repeats is included in GeoJSON data endpoint #2478

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

KipSigei
Copy link
Contributor

Changes / Features implemented

Add support for rendering geoshapes and geotraces in repeat groups

Steps taken to verify this change does what is intended

  • Added tests

Side effects of implementing this change

  • Rendering geojson for geoshapes and geotraces in repeats

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2420

@KipSigei KipSigei marked this pull request as ready for review September 18, 2023 15:35
@ukanga ukanga changed the title Fix bug with geotrace and geoshapes in repeats Ensure geotrace and geoshape in repeats is included in GeoJSON data endpoint Sep 20, 2023
kelvin-muchiri
kelvin-muchiri previously approved these changes Sep 20, 2023
@KipSigei KipSigei merged commit e98a41a into main Sep 25, 2023
8 checks passed
@KipSigei KipSigei deleted the fix-geotrace-bug-with-repeats branch September 25, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'list' object has no attribute 'split'
3 participants