Save xml to json data in pre-save #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
changed the title
KipSigei
approved these changes
Oct 11, 2023
when asynchronous processing of submissions is enabled, submissions whose json is not yet processed have an empty json on endpoint /api/v1/data/<form_id>. To prevent this from happening, we save the XML to json data during pre-save. The json will later be updated to include the metadata in the post_save signal
kelvin-muchiri
force-pushed
the
bug-submission-empty-dict
branch
from
6cd30b7
to
40e8522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
When asynchronous processing of submissions is enabled, submissions whose json is not yet processed have an empty json on endpoint /api/v1/data/<form_id>. To prevent this from happening, we save the XML to json data during pre-save. The json will later be updated to include the metadata in the post_save signal
Steps taken to verify this change does what is intended
Side effects of implementing this change
Get rid of records with empty json on endpoint `/api/v1/data/<form_id> when processing submissions asynchronously
Before submitting this PR for review, please make sure you have:
Closes #