Improve performance for attachments xform meta permissions check #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KipSigei
force-pushed
the
update-attachment-url
branch
from
7ea9d76
to
2f14a05
Compare
onadata/libs/filters.py
Outdated
| attachment_id = view.kwargs.get("pk") | ||
| attachment = get_object_or_404(Attachment, pk=attachment_id) | ||
| xform = attachment.instance.xform.pk | ||
| self.xform = get_object_or_404(XForm, pk=xform) |
There was a problem hiding this comment.
Why can't we do self.xform = attachment.instance.xform and avoid getting the xform again?
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
KipSigei
force-pushed
the
update-attachment-url
branch
from
2f14a05
to
ba60d8c
Compare
Signed-off-by: Kipchirchir Sigei <[email protected]>
kelvin-muchiri
approved these changes
Nov 6, 2023
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
_xform_filterto handle attachmentsSteps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #