Soft delete xform from legacy UI #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
force-pushed
the
soft-delete-xform-in-legacy-ui
branch
2 times, most recently
from
fc80e9a
to
06bc8c3
Compare
| "submission.xml", | ||
| ) | ||
| self._make_submission(path) | ||
| x += 1 |
There was a problem hiding this comment.
Why do we increment?
There was a problem hiding this comment.
There's no need for, this, I've removed this line
Don't call xform.delete() method which soft deletes
FrankApiyo
force-pushed
the
soft-delete-xform-in-legacy-ui
branch
from
06bc8c3
to
3329c5f
Compare
| @@ -504,8 +503,8 @@ def delete_xform(request, username, id_string): | |||
| {"user__username__iexact": username, "id_string__iexact": id_string} | |||
| ) | |||
|
|
|||
| # delete xform and submissions | |||
| remove_xform(xform) | |||
There was a problem hiding this comment.
Should we also delete the function remove_xform since it is no longer required?
kelvin-muchiri
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't call
xform.delete()method which soft deletesBefore submitting this PR for review, please make sure you have: