Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Handle Statement Timeout in Briefcase Viewset #2508

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Nov 16, 2023

Changes / Features implemented

  • Add Optimization Fence in Briefcase Viewset to handle canceling statement due to statement timeout OperationalError Exception

Steps taken to verify this change does what is intended

  • Added a try catch block to execute the optimization fence query when OperationalError Exception is thrown

Side effects of implementing this change

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

@KipSigei KipSigei force-pushed the optimize-briefcase-viewset branch 4 times, most recently from 53a9478 to 0ef7b83 Compare November 16, 2023 11:37
@KipSigei KipSigei marked this pull request as ready for review November 17, 2023 09:28
@KipSigei KipSigei force-pushed the optimize-briefcase-viewset branch 2 times, most recently from c8d8320 to ef37dec Compare November 21, 2023 18:50
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei merged commit 6a87c3b into main Nov 22, 2023
9 checks passed
@KipSigei KipSigei deleted the optimize-briefcase-viewset branch November 22, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants