Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore child questions of grouped sections within repeating sections during CSV export #2559

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

kelvin-muchiri
Copy link
Contributor

@kelvin-muchiri kelvin-muchiri commented Feb 22, 2024

Changes / Features implemented

  • Fix bug where child questions of grouped sections that are children of repeating sections are not ignored during CSV export therefore appearing as extra column headers
  • Fix flaky test onadata.apps.api.tests.viewsets.test_charts_viewset.TestChartsViewSet.test_charts_group_by_select_one

Steps taken to verify this change does what is intended

  • QA
  • Tests

Side effects of implementing this change

No side effects

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #2562

@kelvin-muchiri kelvin-muchiri marked this pull request as draft February 22, 2024 14:17
@kelvin-muchiri kelvin-muchiri changed the title Ignore child questions of repeating questions Ignore child questions of grouped sections within repeating sections Feb 23, 2024
@kelvin-muchiri kelvin-muchiri changed the title Ignore child questions of grouped sections within repeating sections Ignore child questions of grouped sections within repeating sections during CSV export Feb 23, 2024
@kelvin-muchiri kelvin-muchiri marked this pull request as ready for review February 23, 2024 13:28
@kelvin-muchiri kelvin-muchiri merged commit e0ef23c into main Feb 27, 2024
9 checks passed
@kelvin-muchiri kelvin-muchiri deleted the bug-repeat-in-group-export branch February 27, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child questions of grouped sections within repeating sections not ignored during CSV export
2 participants