Entities search #2643
Merged
Entities search #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
force-pushed
the
entities-search
branch
from
519840f
to
42a08dc
Compare
|
@kelvin-muchiri this is working as expected |
kelvin-muchiri
requested review from
KipSigei,
ukanga,
FrankApiyo and
ciremusyoka
ukanga
reviewed
Jul 11, 2024
| if search: | ||
| queryset = queryset.filter(Q(json__iregex=search) | Q(uuid=search)) | ||
|
|
||
| queryset = queryset.order_by("id") |
There was a problem hiding this comment.
Is the order by necessary? Is it likely to be a performance bottleneck?
There was a problem hiding this comment.
@ukanga Even if we choose not to order by default but it will still be required if pagination is applied
There was a problem hiding this comment.
@kelvin-muchiri we fetch this data paginated
ukanga
approved these changes
Jul 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Add search filter support for Entities
Steps taken to verify this change does what is intended
Before submitting this PR for review, please make sure you have: