Add support for defining Entity properties within grouped sections #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
force-pushed
the
entities-grouped-section
branch
from
83fdbc8
to
f1fc98c
Compare
kelvin-muchiri
changed the title
kelvin-muchiri
requested review from
ukanga,
KipSigei,
FrankApiyo and
ciremusyoka
KipSigei
reviewed
Jul 15, 2024
onadata/libs/utils/logger_tools.py
Outdated
| # Handle repeat question | ||
| for child_data in data[field_name]: | ||
| parse_instance_json(child_data) | ||
| temp = data[field_name] |
There was a problem hiding this comment.
Can we rename temp var to be more descriptive?
|
This has been implemented. Tested on stage.ona.io |
FrankApiyo
approved these changes
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Add support for creating Entity properties defined within grouped sections
Steps taken to verify this change does what is intended
Before submitting this PR for review, please make sure you have: