Remove default ordering on XForm, Attachment model #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordering creates a performance bottleneck and should be avoided if unnecessary
kelvin-muchiri
requested review from
ukanga,
ciremusyoka,
FrankApiyo and
KipSigei
kelvin-muchiri
changed the title
FrankApiyo
approved these changes
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Remove default ordering on models XForm and Attachment. Ordering creates a performance bottleneck and should only be applied when necessary e.g during pagination
Side effects of implementing this change
Faster queries when fetching records