Exclude deleted Entities from form's manifest data #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
changed the title
kelvin-muchiri
changed the title
kelvin-muchiri
changed the title
kelvin-muchiri
changed the title
kelvin-muchiri
requested review from
KipSigei,
ciremusyoka,
ukanga and
FrankApiyo
kelvin-muchiri
changed the title
KipSigei
suggested changes
Jul 24, 2024
| queryset = obj.follow_up_forms.all() | ||
| queryset = obj.follow_up_forms.filter( | ||
| entity_list__deleted_at__isnull=True | ||
| ).all() |
KipSigei
approved these changes
Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Exclude deleted EntityList and Entity in the endpoints:
/<username>/xformsManifest/<form_id>/<username>/xformsMedia/<form_id>/<media_id>.csv/api/v1/projectsCreated index for
deleted_atcolumn on model EntityList and EntitySteps taken to verify this change does what is intended
Before submitting this PR for review, please make sure you have:
Closes #2649