Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add throttling based on URL #2674

Closed
wants to merge 4 commits into from
Closed

Add throttling based on URL #2674

wants to merge 4 commits into from

Conversation

FrankApiyo
Copy link
Member

@FrankApiyo FrankApiyo commented Aug 22, 2024

Changes / Features implemented

Steps taken to verify this change does what is intended

Side effects of implementing this change

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

@FrankApiyo FrankApiyo changed the title Add throttling changes Add throttling based on URL Aug 22, 2024
@FrankApiyo FrankApiyo marked this pull request as ready for review August 23, 2024 08:04
@FrankApiyo FrankApiyo force-pushed the add-throttling-changes branch 3 times, most recently from 130f34e to 0628b51 Compare August 24, 2024 17:29
kelvin-muchiri
kelvin-muchiri previously approved these changes Aug 26, 2024
Copy link
Member

@ukanga ukanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This targets only submissions. Can it be generic enough to handle different paths and request methods?

@FrankApiyo
Copy link
Member Author

This targets only submissions. Can it be generic enough to handle different paths and request methods?

It seemed appropriate to only target the submission endpoint(s) for now because performance/scaling issues triggered on the submission endpoints.

Copy link
Member

@ukanga ukanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we throttle more than one endpoint at a time?

@ukanga
Copy link
Member

ukanga commented Aug 27, 2024

It seemed appropriate to only target the submission endpoint(s) for now because performance/scaling issues triggered on the submission endpoints.

I think it makes sense to be generic since we have had other endpoints that have required similar treatment. Also, as stated in another comment, this seems to only handle one endpoint at a time. Let's account for more than one URL path.

@FrankApiyo
Copy link
Member Author

These changes have been superseded by #2685

@FrankApiyo FrankApiyo closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants