-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add throttling based on URL #2674
Conversation
830c0ba
to
19f0c39
Compare
130f34e
to
0628b51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This targets only submissions. Can it be generic enough to handle different paths and request methods?
0628b51
to
25e9d5c
Compare
It seemed appropriate to only target the submission endpoint(s) for now because performance/scaling issues triggered on the submission endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we throttle more than one endpoint at a time?
I think it makes sense to be generic since we have had other endpoints that have required similar treatment. Also, as stated in another comment, this seems to only handle one endpoint at a time. Let's account for more than one URL path. |
These changes have been superseded by #2685 |
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #