Wait for transaction to complete before calling webhooks #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukanga
approved these changes
Aug 23, 2024
fix exception AttributeError: 'ParsedInstance' object has no attribute 'xform'
kelvin-muchiri
added a commit
that referenced
this pull request
Aug 23, 2024
* fix stale data sent to rest services when editing submission The data sent to rest services can be stale if the instance is not yet saved to the database when a submission is edited * pin to master * add comment * fix typo in comment * Wait for transaction to complete before calling webhooks (#2675) * wait for transaction to complete before calling webhooks * refactor code * refactor code * fix exception fix exception AttributeError: 'ParsedInstance' object has no attribute 'xform' * fix failing tests capture on commit callbacks * move misplaced comment * use master database when calling external services Call webhooks is a second-effect of creating/updating a submission. The operation should be pinned to master database, so that the replicas can be used by the clients reading from the API * fix failing tests * fix failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Wait for transaction to complete before calling webhooks