Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache xform list results #2692

Merged
merged 12 commits into from
Sep 2, 2024
Merged

Cache xform list results #2692

merged 12 commits into from
Sep 2, 2024

Conversation

kelvin-muchiri
Copy link
Contributor

@kelvin-muchiri kelvin-muchiri commented Sep 2, 2024

Changes / Features implemented

Cache xform list results by users role.
Move methods to resolve cyclic dependency errors.

Limitations

The cache is only invalidated at expiry time. The expiry time is set at 10 minutes. Cache invalidation when a form is deleted/added will be added in future.

Steps taken to verify this change does what is intended

  • Added tests

Side effects of implementing this change

Before submitting this PR for review, please make sure you have:

  • Included tests

@kelvin-muchiri kelvin-muchiri marked this pull request as ready for review September 2, 2024 11:11
@kelvin-muchiri kelvin-muchiri merged commit bef5d30 into main Sep 2, 2024
10 checks passed
@kelvin-muchiri kelvin-muchiri deleted the cache-xform-list branch September 2, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants