Redirect client to download media directly from Amazon S3 / Azure Storage #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
force-pushed
the
exports-download-url
branch
from
ce20376
to
782fcdb
Compare
kelvin-muchiri
force-pushed
the
exports-download-url
branch
from
7fdea77
to
1ac4f0c
Compare
kelvin-muchiri
changed the title
kelvin-muchiri
changed the title
FrankApiyo
reviewed
Oct 8, 2024
Comment on lines
1743
to
1746
| # # Anonymous user cannot view private EntityList | ||
| # request = self.factory.get("/") | ||
| # response = self.view(request, pk=self.entity_list.pk) | ||
| # self.assertEqual(response.status_code, 404) |
There was a problem hiding this comment.
Does this mean that anonymous users can now view private EntityLists?
There was a problem hiding this comment.
@FrankApiyo Nice catch, I don't think this was intentional
FrankApiyo
reviewed
Oct 8, 2024
| request = self.factory.get("/export") | ||
| force_authenticate(request, user=self.user) | ||
| response = self.view(request, pk=export.pk) | ||
| self.assertEqual(response.status_code, 302, response.url) |
There was a problem hiding this comment.
What does the 3rd argument to assertEqual do?
There was a problem hiding this comment.
@FrankApiyo I copied the assertion from a previous implementation. I will remove it since the 3rd argument should be the message displayed if the assertion fails.
FrankApiyo
reviewed
Oct 8, 2024
Comment on lines
-752
to
+878
| return f"attachment; filename={name}.{extension}" | ||
| # The filename is enclosed in quotes because it ensures that special characters, | ||
| # spaces, or punctuation in the filename are correctly interpreted by browsers | ||
| # and clients. This is particularly important for filenames that may contain | ||
| # spaces or non-ASCII characters. |
ukanga
approved these changes
Oct 9, 2024
FrankApiyo
approved these changes
Oct 9, 2024
kelvin-muchiri
force-pushed
the
exports-download-url
branch
from
6a6afb5
to
92f95aa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Redirect client to download media directly from Amazon S3 / Azure Storage. Before, the server was responsible for reading the file contents and streaming the data back to the client. This implementation was prone to timeouts if the file is large and required the server to adjust UWSGI and Nginx timeouts to large values.
Deployments that choose to use local storage are not affected by the change.
Steps taken to verify this change does what is intended
Side effects of implementing this change
Prevents large exports from timing out
Before submitting this PR for review, please make sure you have:
Closes #