Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies; removed pointer analyzer as it panics in go 1.22; updated readme and gitignore #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Egor3f
Copy link

@Egor3f Egor3f commented Mar 29, 2024

fixes #170

@tenax66
Copy link

tenax66 commented May 9, 2024

Will this be merged? There are many issues regarding pointer analysis.

Since golang.org/x/tools/go/pointer has been deprecated, we should either remove it (as it is in this PR), or at least change the default analysis.

@starius
Copy link

starius commented May 13, 2024

Strong +1 for this PR!
It fixed go-callvis crash in my project. I'm using Go 1.22

@mangoNisa
Copy link

+1 for the PR, im also using Go 1.22 and this fixed the error

minias added a commit to minias/go-callvis that referenced this pull request Jun 26, 2024
minias added a commit to minias/go-callvis that referenced this pull request Jun 26, 2024
@mztnnrt
Copy link

mztnnrt commented Jul 19, 2024

Also in my environment, this pr is correctly work, Thanks.

git clone https://github.com/ofabry/go-callvis.git
cd go-callvis

gh co 177 # checkout to this nice pull request.
make install
go-callvis .
2024/07/18 15:45:40 http serving at http://localhost:7878
2024/07/18 15:45:40 converting dot to svg..
2024/07/18 15:45:40 serving file: /var/folders/../../go-callvis_export.svg

@githoober
Copy link

Is there anyone besides @ondrajz who can merge this PR?

@mmihira
Copy link

mmihira commented Oct 5, 2024

With 1.23.1 , getting this error now on this branch

panic: Cannot range over: func(yield func(K, V) bool)

@wangzhankun
Copy link

Will this be merged? There are many issues regarding pointer analysis.

Copy link

@wangzhankun wangzhankun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main changes to the code are:

  1. Removed the code related to "golang.org/x/tools/go/pointer" and its associated code, as it caused numerous issues.
  2. Added the -algo parameter.
  3. Upgraded the Go version to 1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got error running go-callvis on github.com/googlecloudplatform/gcsfuse
8 participants