Fix backwards compatibility usage of Get*ProcAddrTable #231
+96
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will support drivers implementing only spec 1.0 functions |
|
Can you do the same in the zesDdiTableInit and zetDdiTableInit because the error will occur there too. |
|
Just double checking, this isn't something that needs added to the Mako scripts? |
Make the results of certain Get*ProcAddrTable calls in ze_libddi.cpp ignored as not all drivers will implement these functions. These functions populate different sections of DDI tables in the lib component. Fixes oneapi-src#196 Relates to VLCLJ-2339 Signed-off-by: Lisanna Dettwyler <[email protected]>
lisanna-dettwyler
force-pushed
the
fix-getprocaddrtable
branch
from
1e8cefe
to
c54ff25
Compare
nrspruit
approved these changes
Nov 9, 2024
nrspruit
requested changes
Nov 9, 2024
There was a problem hiding this comment.
Add the logic to generate this code from https://github.com/oneapi-src/level-zero/blob/master/scripts/templates/libddi.cpp.mako
Yes, I just realized, this will need to be changed here such that the code gen will create this: |
nrspruit
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the results of certain Get*ProcAddrTable calls in ze_libddi.cpp ignored as not all drivers will implement these functions. These functions populate different sections of DDI tables in the lib component.
Fixes #196
Relates to VLCLJ-2339