cpu: x64: brgemm: use range-based loop for jit_brgemm_amx_uker.cpp #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:cpu-x64
|
It seems to be a purely stylistic change. Given that PR review and merging is a rather manual work, we would be grateful if you could focus on more impactful changes (e.g. improving safety of the library, or fixing actual issues). |
mgouicem
approved these changes
Oct 3, 2024
spalicki
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code changes in this PR were generated automatically by the Permanence AI Coder and reviewed by @eelenberg and @jweese. This PR replaces iteration-based for loops over members of
tloopwith range-based for loops, which removes unnecessary indexing variables, improves readability, and reduces potential off-by-one errors. This PR is effectively applying the update from #2086 to an additional file.on-behalf-of: @permanence-ai [email protected]
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?