Make Copy_if family of APIs use reduce_then_scan algorithm #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
4 times, most recently
from
b517414
to
d85ce61
Compare
danhoeflinger
force-pushed
the
dev/shared/transform_reduce_then_scan
branch
from
9eb3099
to
fc43983
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
3 times, most recently
from
e33efaa
to
5f4882a
Compare
danhoeflinger
force-pushed
the
dev/shared/transform_reduce_then_scan
branch
from
6cb5fc1
to
82f3ee5
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
3 times, most recently
from
6696396
to
f757df5
Compare
This was referenced Aug 6, 2024
danhoeflinger
changed the title
This was referenced Aug 6, 2024
danhoeflinger
force-pushed
the
dev/shared/transform_reduce_then_scan
branch
from
4df758a
to
690e121
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
f757df5
to
3301a89
Compare
danhoeflinger
force-pushed
the
dev/shared/transform_reduce_then_scan
branch
from
690e121
to
d0ef883
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
3301a89
to
000a823
Compare
danhoeflinger
commented
Aug 7, 2024
adamfidel
reviewed
Aug 7, 2024
adamfidel
reviewed
Aug 7, 2024
mmichel11
reviewed
Aug 7, 2024
mmichel11
reviewed
Aug 7, 2024
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
d318354
to
1da7875
Compare
julianmi
previously approved these changes
Aug 29, 2024
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
1da7875
to
8601892
Compare
danhoeflinger
commented
Aug 29, 2024
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
8601892
to
df02a01
Compare
This reverts commit 75eeca8.
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
… another instance Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Matthew Michel <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
df02a01
to
75c55c4
Compare
julianmi
previously approved these changes
Aug 30, 2024
adamfidel
previously approved these changes
Aug 30, 2024
Signed-off-by: Dan Hoeflinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds copy_if family to use reduce_then_scan algorithm where it is beneficial.
Moves all algorithm selection decisions to
__parallel_copy_if, and unifies range API to also use this function. Adding support for an assignment operator for single work group copy_if. This allows us to unify the algorithmic selection, and provide performance improvements to the ranges API.Adds
__parallel_reduce_then_scan_copyfunction which will be used by partition and unique in the future to take advantage of shared functionality.This PR is targeted to #1762, to allow for a clean diff, and is a part of the following sequence of PRs meant to be merged in order:
#1769 [MERGED]
Relocate __lazy_ctor_storage to utils header#1770 [MERGED]
Use __result_and_scratch_storage within scan kernels#1762 Add reduce_then_scan algorithm for transform scan family
#1763 Make Copy_if family of APIs use reduce_then_scan algorithm (This PR)
#1764 Make Partition family of APIs use reduce_then_scan algorithm
#1765 Make Unique family of APIs use reduce_then_scan algorithm
This work is a collaboration between @mmichel11 @adamfidel and @danhoeflinger, and based upon an original prototype by Ted Painter.