Skip to content

Commit

Permalink
feat: hard coded search config (#42)
Browse files Browse the repository at this point in the history
* feat: P002271-6127 emit SearchConfig

* feat: add additionalToolBarActions to page header and to search header

* feat: hardcoded search config as a template
and provided with translations

* feat: test harness adapted and tests added

* fix: remove unused imports and variables

* fix: rename defaultTranslationKey to
 placeholderKey

* fix: adaption of the action version

* fix: change primeng version back

* fix: downgrading primeNG version

The primeNG version 15.2.1 was the last version where this issue
primefaces/primeng#13024 was not occuring for us

Before upgrading this version, please check if the tests are running with
npx nx affected -t test --configuration=ci --skip-nx-cache

* fix: add missing test to check if the dropdown
disappears when the searchconfig is empty
  • Loading branch information
anninowak authored Dec 14, 2023
1 parent fea1299 commit c94cde3
Show file tree
Hide file tree
Showing 20 changed files with 5,957 additions and 7,983 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@ name: build
on:
push:
branches:
- '*'
- '*/*'
- '**'
- "*"
- "*/*"
- "**"
pull_request:
branches:
branches:
- main
jobs:
main:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 18
- uses: nrwl/nx-set-shas@v3
- name: Install deps
run: npm ci
Expand Down
3 changes: 3 additions & 0 deletions libs/portal-integration-angular/assets/i18n/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
"BASIC": "Basis",
"ADVANCED": "Erweitert"
},
"OCX_SEARCH_CONFIG": {
"DROPDOWN_DEFAULT": "Gespeicherte Suchvorlage auswählen"
},
"HEADLINE": "Suche",
"RESET_BUTTON_TEXT": "Zurücksetzen",
"SEARCH_BUTTON_TEXT": "Suchen",
Expand Down
3 changes: 3 additions & 0 deletions libs/portal-integration-angular/assets/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
"BASIC": "Basic",
"ADVANCED": "Advanced"
},
"OCX_SEARCH_CONFIG": {
"DROPDOWN_DEFAULT": "Pick predefined template"
},
"HEADLINE": "Search",
"RESET_BUTTON_TEXT": "Reset",
"SEARCH_BUTTON_TEXT": "Search",
Expand Down
Loading

0 comments on commit c94cde3

Please sign in to comment.