-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2296 from onevcat/fix/kfimage-tapping
Align animated image interaction behavior to normal image and iOS 17
- Loading branch information
Showing
4 changed files
with
92 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
Demo/Demo/Kingfisher-Demo/SwiftUIViews/Regression/Issue2295View.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| // | ||
| // Issue2295View.swift | ||
| // Kingfisher | ||
| // | ||
| // Created by onevcat on 2024/09/21. | ||
| // | ||
| // Copyright (c) 2024 Wei Wang <[email protected]> | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| import SwiftUI | ||
| import Kingfisher | ||
|
|
||
| @available(iOS 14.0, *) | ||
| struct Issue2295View: View { | ||
|
|
||
| @State private var count = 0 | ||
|
|
||
| var body: some View { | ||
| Text("This is a test case for #2295") | ||
| Text("Count: \(count)") | ||
| ScrollView { | ||
| VStack { | ||
| Text("Tapping these to add count.") | ||
| HStack { | ||
| KFImage(ImageLoader.sampleImageURLs.first) | ||
| .resizable() | ||
| .frame(width: 150, height: 150) | ||
| .onTapGesture { | ||
| count += 1 | ||
| } | ||
| KFAnimatedImage(ImageLoader.sampleImageURLs.first) | ||
| .frame(width: 150, height: 150) | ||
| .onTapGesture { | ||
| count += 1 | ||
| } | ||
| } | ||
| } | ||
| Divider() | ||
| VStack { | ||
| Text("These are not tappable.") | ||
| HStack { | ||
| KFImage(ImageLoader.sampleImageURLs.first) | ||
| .resizable() | ||
| .frame(width: 150, height: 150) | ||
| .allowsHitTesting(false) | ||
| .onTapGesture { | ||
| count += 1 | ||
| } | ||
| KFAnimatedImage(ImageLoader.sampleImageURLs.first) | ||
| .frame(width: 150, height: 150) | ||
| .allowsHitTesting(false) | ||
| .onTapGesture { | ||
| count += 1 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @available(iOS 14.0, *) | ||
| struct Issue2295View_Previews: PreviewProvider { | ||
| static var previews: some View { | ||
| Issue1998View() | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters