Change Array.Get() to return Value instead of Storable
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxamacker
added
improvement
breaking change
This commit changes Array.Get() to return Value instead of Storable. Currently, Array.Get() returns Storable and client converts returned Storable to Value. However, it only makes sense to return Storable if client needs to remove register (slab) by StorageID (StorageIDStorable). Get() should only provide value without possibility of client manipulating the underlying storable.
fxamacker
force-pushed
the
fxamacker/change-array-get-to-return-value
branch
from
c182da1
to
044db01
Compare
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 64.62% 64.60% -0.03%
==========================================
Files 14 14
Lines 7991 8000 +9
==========================================
+ Hits 5164 5168 +4
- Misses 2152 2155 +3
- Partials 675 677 +2
|
This was referenced Jun 27, 2023
fxamacker
added a commit
to onflow/cadence
that referenced
this pull request
Jun 29, 2023
This commit updates Cadence to use new Atree API - Array.Get() - OrderedMap.Get() - MaxInlineArrayElementSize() - MaxInlineMapKeySize() For more info, see Atree PRs: - onflow/atree#314 - onflow/atree#316 - onflow/atree#318
6 tasks
turbolent
pushed a commit
to onflow/cadence
that referenced
this pull request
Jan 26, 2024
This commit updates Cadence to use new Atree API - Array.Get() - OrderedMap.Get() - MaxInlineArrayElementSize() - MaxInlineMapKeySize() For more info, see Atree PRs: - onflow/atree#314 - onflow/atree#316 - onflow/atree#318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #315
Updates #296 #292
Description
This PR changes
Array.Get()to returnValueinstead ofStorable.Currently,
Array.Get()returnsStorableand client converts returnedStorabletoValue. However, it only makes sense to returnStorableif client needs to remove register (slab) byStorageID(StorageIDStorable).Get()should only provideValuewithout possibility of client manipulating the underlyingStorable.This is prep work for Atree Register Inlining (#292) and will also harden the API.
mainbranchFiles changedin the Github PR explorer