Check mutation of elements from readonly array iterator #411
+323
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #409
Projects using atree might unintentionally mutate elements returned by readonly iterators.
As always, mutation of elements from readonly iterators are not guaranteed to persist.
This PR returns error from mutation functions, and supports callback functions that allow projects using atree to log or debug such mutations with extra context, panic, etc.
If elements from readonly iterators are mutated:
ReadOnlyIteratorElementMutationError
.ReadOnlyArrayIteratorMutationCallback
are called (if provided and mutation occurs).Callback function can be provided by using
ReadOnlyIteratorWithMutationCallback
.Equivalent PR for readonly map iterator is:
main
branchFiles changed
in the Github PR explorer