[LS] Add checker support for BlockchainHelpers identifier location
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
reviewed
Aug 8, 2023
languageserver/go.mod
Outdated
Comment on lines
190
to
192
| replace github.com/onflow/cadence-tools/test => ../test | ||
|
|
||
| replace github.com/onflow/cadence => ../../cadence |
There was a problem hiding this comment.
replace statements should not be comitted
Suggested change
| replace github.com/onflow/cadence-tools/test => ../test | |
| replace github.com/onflow/cadence => ../../cadence |
There was a problem hiding this comment.
Oops yeah 😅
I used them for local development, will get them out 👍
There was a problem hiding this comment.
maybe refer to the commit, until we tag a release
There was a problem hiding this comment.
I think I have tried that before, but it didn't work with forks. I will check again though 👍
There was a problem hiding this comment.
SupunS
approved these changes
Aug 10, 2023
m-Peter
force-pushed
the
ls-add-blockchain-helpers
branch
from
4803a77
to
fe555bc
Compare
SupunS
approved these changes
Aug 11, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #181
Description
The Cadence testing framework has introduced a new identifier location:
BlockchainHelpers, so we add support for it in the language server. Otherwise the checking would fail.masterbranchFiles changedin the Github PR explorer