Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track resources with atree.ID instead of StorageID #2627

Commits on Jun 30, 2023

  1. Delegate Cadence composite Storable() to Atree

    Currently, Cadence ArrayValue, CompositeValue, and DictionaryValue
    creates atree.Storable directly from StorageID of its Atree values.
    
    In the future, some Atree values can be inlined so they don't have
    StorageID, and Atree values need to handle Storable depending
    on maxInlineSize and other factors.
    
    This commit delegates Cadence composite values' Storable() to its
    internal Atree values.  So future changes to Atree values and their
    storables don't break Cadence.
    fxamacker committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    a0ea3d5 View commit details
    Browse the repository at this point in the history
  2. Delegate storage address to Atree

    Currently, storage address is derived from StorageID().
    
    In the future, some Atree values can be inlined so they don't have
    StorageID and address needs be derived differently.
    
    This commit delegates storage address to its internal Atree values,
    by calling Address().
    fxamacker committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    6751377 View commit details
    Browse the repository at this point in the history
  3. Fix data race in type tests

    fxamacker committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    2425f7c View commit details
    Browse the repository at this point in the history
  4. only check program's types

    turbolent committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    ad58840 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Track resources with atree.ID instead of StorageID

    Currently, Array.StorageID() and OrderedMap.StorageID() are used as
    identifier to track resources, etc because storage IDs are guaranteed
    to unique. However, atree storage ID should be only used to retrieve
    slabs (registers) from storage.
    
    Also, when Atree register inlining is implemented in the future, some
    resources may not be stored in separate slabs, so they will not have
    storage IDs anymore.
    
    This commit uses Array.ID() and OrderedMap.ID() to uniquely identify
    resources.
    fxamacker committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    d6c7dfb View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. add mailmap

    turbolent committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    4c29e00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7fc9280 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Merge pull request #2624 from onflow/fxamacker/fix-data-race-in-sema-…

    …type-test
    
    Fix data race in sema/type_test.go
    fxamacker authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    1ec0ec6 View commit details
    Browse the repository at this point in the history
  2. fix races in tests

    turbolent committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    233b1d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1173380 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Merge pull request #2621 from onflow/fxamacker/delegate-cadence-compo…

    …site-storable-to-atree
    
    Delegate Cadence composite `Storable()` to Atree
    fxamacker authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    9397f7b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2622 from onflow/fxamacker/decouple-address-from-…

    …atree-storage-id
    
    Delegate storage address to Atree
    fxamacker authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ffa896e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0e6d04a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f9c5fd View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    f29400f View commit details
    Browse the repository at this point in the history