-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track resources with atree.ID instead of StorageID #2627
Track resources with atree.ID instead of StorageID #2627
Commits on Jun 30, 2023
-
Delegate Cadence composite Storable() to Atree
Currently, Cadence ArrayValue, CompositeValue, and DictionaryValue creates atree.Storable directly from StorageID of its Atree values. In the future, some Atree values can be inlined so they don't have StorageID, and Atree values need to handle Storable depending on maxInlineSize and other factors. This commit delegates Cadence composite values' Storable() to its internal Atree values. So future changes to Atree values and their storables don't break Cadence.
Configuration menu - View commit details
-
Copy full SHA for a0ea3d5 - Browse repository at this point
Copy the full SHA a0ea3d5View commit details -
Delegate storage address to Atree
Currently, storage address is derived from StorageID(). In the future, some Atree values can be inlined so they don't have StorageID and address needs be derived differently. This commit delegates storage address to its internal Atree values, by calling Address().
Configuration menu - View commit details
-
Copy full SHA for 6751377 - Browse repository at this point
Copy the full SHA 6751377View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2425f7c - Browse repository at this point
Copy the full SHA 2425f7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad58840 - Browse repository at this point
Copy the full SHA ad58840View commit details
Commits on Jul 3, 2023
-
Track resources with atree.ID instead of StorageID
Currently, Array.StorageID() and OrderedMap.StorageID() are used as identifier to track resources, etc because storage IDs are guaranteed to unique. However, atree storage ID should be only used to retrieve slabs (registers) from storage. Also, when Atree register inlining is implemented in the future, some resources may not be stored in separate slabs, so they will not have storage IDs anymore. This commit uses Array.ID() and OrderedMap.ID() to uniquely identify resources.
Configuration menu - View commit details
-
Copy full SHA for d6c7dfb - Browse repository at this point
Copy the full SHA d6c7dfbView commit details
Commits on Jul 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4c29e00 - Browse repository at this point
Copy the full SHA 4c29e00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fc9280 - Browse repository at this point
Copy the full SHA 7fc9280View commit details
Commits on Jul 5, 2023
-
Merge pull request #2624 from onflow/fxamacker/fix-data-race-in-sema-…
…type-test Fix data race in sema/type_test.go
Configuration menu - View commit details
-
Copy full SHA for 1ec0ec6 - Browse repository at this point
Copy the full SHA 1ec0ec6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 233b1d8 - Browse repository at this point
Copy the full SHA 233b1d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1173380 - Browse repository at this point
Copy the full SHA 1173380View commit details
Commits on Jul 6, 2023
-
Merge pull request #2621 from onflow/fxamacker/delegate-cadence-compo…
…site-storable-to-atree Delegate Cadence composite `Storable()` to Atree
Configuration menu - View commit details
-
Copy full SHA for 9397f7b - Browse repository at this point
Copy the full SHA 9397f7bView commit details -
Merge pull request #2622 from onflow/fxamacker/decouple-address-from-…
…atree-storage-id Delegate storage address to Atree
Configuration menu - View commit details
-
Copy full SHA for ffa896e - Browse repository at this point
Copy the full SHA ffa896eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e6d04a - Browse repository at this point
Copy the full SHA 0e6d04aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f9c5fd - Browse repository at this point
Copy the full SHA 9f9c5fdView commit details
Commits on Jul 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f29400f - Browse repository at this point
Copy the full SHA f29400fView commit details